-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-17345][python][table] Support register and get Python UDF in Catalog. #11884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit ecd6631 (Thu Apr 23 12:20:45 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
| final Catalog catalog = catalogManager.getCatalog(normalizedIdentifier.getCatalogName()) | ||
| .orElseThrow(IllegalStateException::new); | ||
| final ObjectPath path = identifier.toObjectPath(); | ||
| final CatalogFunction catalogFunction = new CatalogFunctionImpl( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the aim of this change? It seems to me there is no difference between the changed logic and the original logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial reason of this change is provide an approach in FunctionCatalog to register Python CatalogFunction. But it seems not necessary now because the upper layer accesses the Catalog object directly.
|
|
||
| @Override | ||
| public boolean isGeneric() { | ||
| if (functionLanguage == FunctionLanguage.PYTHON) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the aim of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the Python UDF is always generic and can not be loaded via Class.forName. So just return true if the CatalogFunction is a Python UDF.
570f7e2 to
3579637
Compare
|
@dianfu Thanks for your review! I have addressed you comments in the latest commit. |
|
@WeiZhong94 Thanks a lot for the update. Will merge once the travis/azure turns green. |
What is the purpose of the change
This pull request supports register and get Python UDF in catalog via sql ddl.
Brief change log
Verifying this change
This change is already covered by existing tests, such as PythonFunctionFactoryTest, HiveCatalogTest, GenericInMemoryCatalogTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation