Skip to content

Conversation

@WeiZhong94
Copy link
Contributor

What is the purpose of the change

This pull request supports register and get Python UDF in catalog via sql ddl.

Brief change log

  • Support register python catalog UDF via SQL DDL.
  • Support create, get and alter python catalog UDF in HiveCatalog.

Verifying this change

This change is already covered by existing tests, such as PythonFunctionFactoryTest, HiveCatalogTest, GenericInMemoryCatalogTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit ecd6631 (Thu Apr 23 12:20:45 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 23, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

final Catalog catalog = catalogManager.getCatalog(normalizedIdentifier.getCatalogName())
.orElseThrow(IllegalStateException::new);
final ObjectPath path = identifier.toObjectPath();
final CatalogFunction catalogFunction = new CatalogFunctionImpl(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the aim of this change? It seems to me there is no difference between the changed logic and the original logic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial reason of this change is provide an approach in FunctionCatalog to register Python CatalogFunction. But it seems not necessary now because the upper layer accesses the Catalog object directly.


@Override
public boolean isGeneric() {
if (functionLanguage == FunctionLanguage.PYTHON) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the aim of this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the Python UDF is always generic and can not be loaded via Class.forName. So just return true if the CatalogFunction is a Python UDF.

@WeiZhong94 WeiZhong94 force-pushed the FLINK-17345 branch 2 times, most recently from 570f7e2 to 3579637 Compare April 24, 2020 02:51
@WeiZhong94
Copy link
Contributor Author

@dianfu Thanks for your review! I have addressed you comments in the latest commit.

@dianfu
Copy link
Contributor

dianfu commented Apr 24, 2020

@WeiZhong94 Thanks a lot for the update. Will merge once the travis/azure turns green.

@dianfu dianfu merged commit 90fed72 into apache:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants