[FLINK-2725] Max/Min/Sum Aggregation of mutable types#1191
[FLINK-2725] Max/Min/Sum Aggregation of mutable types#1191greghogan wants to merge 1 commit intoapache:masterfrom
Conversation
|
Looks like a solid addition. Out of curiosity: Have you made any experiments or microbenchmarks about how this impacts performance? |
|
@StephanEwen, I have not yet created or run any microbenchmarks. Are you thinking of comparing immutable aggregators with and without this patch or comparing mutable and immutable aggregators? |
There was a problem hiding this comment.
Is the purpose of these statics that users's don't have to instantiate them themselves?
I'm just wondering because IntelliJ is marking some of them as unused.
There was a problem hiding this comment.
Yes, these follow the form of BasicTypeInfo (which, admittedly, are much longer instantiations). These are used extensively in ValueCollectionDataSets for creation of TupleTypeInfo and which mirrors CollectionDataSets which uses the BasicTypeInfo statics for the same purpose.
I am surprised IntelliJ is marking public members as unused.
|
Thanks for the PR! |
No description provided.