-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-17483][legal] Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies #11965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… file to correctly reflect bundled dependencies
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 4061d02 (Thu Apr 30 18:07:33 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
|
||
| This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) | ||
|
|
||
| - com.carrotsearch:hppc:0.8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hppc has a NOTICE file that we need to forward: https://github.com/carrotsearch/hppc/blob/0.8.1/NOTICE.txt
I could not find it in this archive: https://repository.apache.org/content/repositories/orgapacheflink-1362/org/apache/flink/flink-sql-connector-elasticsearch7_2.11/1.10.1/flink-sql-connector-elasticsearch7_2.11-1.10.1.jar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the jar does not contain the NOTICE we do not have to forward it imo.
(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this pointer! I learned something new about licenses tonight.
I rest my case.
rmetzger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for addressing the licensing issues.
The added licenses are all ASL 2.0. I found one problem with the NOTICE file. Otherwise, the change is good to go
zentol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Let's keep in mind that master will need an updated version since we use a different elasticsearch version there.
rmetzger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm +1 after consulting with Chesnay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @carp84 for working on this.
|
Thanks all for the review, and thanks @zentol for the reminder, will open another PR against master branch and watch the version updates of es. |
… file to correctly reflect bundled dependencies This closes #11965.
What is the purpose of the change
Fix the legal issue in
flink-sql-connector-elasticsearch7as reported by FLINK-17483Brief change log
Update flink-sql-connector-elasticsearch7 NOTICE file to correctly reflect bundled dependencies, including:
Verifying this change
Manually compare the output of shaded plugin and the entries in the NOTICE file, make sure they are in accordance.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation