Skip to content

Conversation

@fpompermaier
Copy link
Contributor

@fpompermaier fpompermaier commented May 5, 2020

What is the purpose of the change

Add the implementation of the Oracle dialect for JDBC connectors

Brief change log

  • Implemented OracleDialect extending AbstractDialect in JDBCDIalects
  • Added default OracleRowConverter
  • Added getMergeIntoStatement() into JDBCDialect to handle upsert

Verifying this change

I tested this change connecting directly to a running database (but I didn't cover all the types).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? docs

@flinkbot
Copy link
Collaborator

flinkbot commented May 5, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8ab267b (Fri May 28 08:16:10 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented May 5, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@eskabetxe
Copy link
Member

@fpompermaier could you solve the conflicts..
@wuchong could you check this

@cmdares
Copy link

cmdares commented Dec 11, 2020

https://ci.apache.org/projects/flink/flink-docs-release-1.12/zh/dev/table/connectors/jdbc.html

Database Upsert Grammar
MySQL INSERT .. ON DUPLICATE KEY UPDATE ..
PostgreSQL INSERT .. ON CONFLICT .. DO UPDATE SET ..
**Oracle Merge into
merge into [target-table] A using [source-table sql] B on ([conditional expression] and [...]...)
when matched then [update sql]
when not matched then [insert sql]**

@qinjunjerry
Copy link
Contributor

@fpompermaier anything pending before the conflicts can be solved and the PR to be merged?

@eskabetxe
Copy link
Member

I resolved the conflicts and update to new changes introduced in https://issues.apache.org/jira/browse/FLINK-24253 here #17676

@MartijnVisser
Copy link
Contributor

@eskabetxe I misread your comment, thanks for the PR! I'll try to find a reviewer for that.

@leonardBang
Copy link
Contributor

Thanks @fpompermaier and @eskabetxe for the contribution to support Oracle Database, I close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants