-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-14100][jdbc] Added Oracle dialect #11999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 8ab267b (Fri May 28 08:16:10 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
@fpompermaier could you solve the conflicts.. |
|
https://ci.apache.org/projects/flink/flink-docs-release-1.12/zh/dev/table/connectors/jdbc.html
|
|
@fpompermaier anything pending before the conflicts can be solved and the PR to be merged? |
|
I resolved the conflicts and update to new changes introduced in https://issues.apache.org/jira/browse/FLINK-24253 here #17676 |
|
@eskabetxe I misread your comment, thanks for the PR! I'll try to find a reviewer for that. |
|
Thanks @fpompermaier and @eskabetxe for the contribution to support Oracle Database, I close this PR now. |
What is the purpose of the change
Add the implementation of the Oracle dialect for JDBC connectors
Brief change log
Verifying this change
I tested this change connecting directly to a running database (but I didn't cover all the types).
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation