Skip to content

[FLINK-14920] [flink-end-to-end-perf-tests] Set up environment to run performance e2e tests #10436#12088

Closed
Li-Aihua wants to merge 24 commits intoapache:masterfrom
Li-Aihua:new_env_performance
Closed

[FLINK-14920] [flink-end-to-end-perf-tests] Set up environment to run performance e2e tests #10436#12088
Li-Aihua wants to merge 24 commits intoapache:masterfrom
Li-Aihua:new_env_performance

Conversation

@Li-Aihua
Copy link

What is the purpose of the change

Add funcion to set up environment to run performance e2e tests which methoned in .FLINK-14920

Brief change log

This change added script to set up environment to run performance e2e tests

Verifying this change

Manually verified that can run correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8b96454 (Mon May 11 14:08:22 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented May 11, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Li-Aihua
Copy link
Author

@zentol I'm so sorry to reply to you so later.
I closed this pr: #10436 by my mistake, so i submit this pr now.
i see your opinion in this branch: https://github.com/zentol/flink/tree/14920_wip, I think it's make sense. so i do some things based your code:

  1. about SshTool: Because start-cluster.sh requires passwordless SSH to be setup, and config username/password in confgure file is not safe, I think username/password aren't necessary ,the current user and rsa public key is enough.
  2. other TODOs: i have done almost todo list in your branch
    please review it again. I‘ll reply to you as soon as possible. thanks a lot

@zentol
Copy link
Contributor

zentol commented May 14, 2020

@Li-Aihua Thanks, I will try to take a look next week!

@zentol zentol removed their assignment Mar 4, 2024
@github-actions
Copy link

This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the [community](https://flink.apache.org/what-is-flink/community/).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 90 days, it will be automatically closed.

@github-actions
Copy link

This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants