Skip to content

[FLINK-17538][hbase] Refactor flink-hbase connector structure #12102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wuchong merged 1 commit into from
May 14, 2020
Merged

[FLINK-17538][hbase] Refactor flink-hbase connector structure #12102

wuchong merged 1 commit into from
May 14, 2020

Conversation

@wuchong
Copy link
Member

@wuchong wuchong commented May 12, 2020

What is the purpose of the change

This pull request refactor flink-hbase connector structure and make it align with others in connector family.

Brief change log

  • Move all the classes and interface from org.apache.flink.addons.hbase into org.apache.flink.connector.hbase.
  • Keep TableInputFormat in the original place and deprecate it.
  • Move classes into more structured packges, e.g. source, sink, options.
  • Rename module name to flink-connector-hbase.

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@wuchong wuchong requested a review from JingsongLi May 12, 2020 15:50
@wuchong
Copy link
Member Author

wuchong commented May 12, 2020

cc @leonardBang

@flinkbot
Copy link
Collaborator

flinkbot commented May 12, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 5e6e8df (Tue May 12 15:53:12 UTC 2020)

Warnings:

  • 3 pom.xml files were touched: Check for build and licensing issues.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented May 12, 2020 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

JingsongLi
JingsongLi approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left some minor comments.
And InputFormatForTestTable should extends HBaseInputFormat.

docs/dev/table/connect.md Outdated
| Apache Kafka | 0.11 | `flink-connector-kafka-0.11` | [Download](https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kafka-0.11{{site.scala_version_suffix}}/{{site.version}}/flink-sql-connector-kafka-0.11{{site.scala_version_suffix}}-{{site.version}}.jar) |
| Apache Kafka | 0.11+ (`universal`) | `flink-connector-kafka` | [Download](https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kafka{{site.scala_version_suffix}}/{{site.version}}/flink-sql-connector-kafka{{site.scala_version_suffix}}-{{site.version}}.jar) |
| HBase | 1.4.3 | `flink-hbase` | [Download](https://repo.maven.apache.org/maven2/org/apache/flink/flink-hbase{{site.scala_version_suffix}}/{{site.version}}/flink-hbase{{site.scala_version_suffix}}-{{site.version}}.jar) |
| HBase | 1.4.3 | `flink-connector-hbase` | [Download](https://repo.maven.apache.org/maven2/org/apache/flink/flink-connector-hbase{{site.scala_version_suffix}}/{{site.version}}/flink-connector-hbase{{site.scala_version_suffix}}-{{site.version}}.jar) |
Copy link
Contributor

@JingsongLi JingsongLi May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HBase -> Apache HBase?

...nnector-hbase/src/main/java/org/apache/flink/connector/hbase/source/HBaseLookupFunction.java
* The HBaseLookupFunction is a standard user-defined table function, it can be used in tableAPI
* and also useful for temporal table join plan in SQL.
*/
@Internal
Copy link
Contributor

@JingsongLi JingsongLi May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have testHBaseLookupFunction, do we need expose this?

Copy link
Member Author

@wuchong wuchong May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testHBaseLookupFunction is a temporary solution when this test was introduced, because temporal join is not supported at that time. I will refactor the tests in the next pull request. So I think we don't need to expose this class.

wuchong added a commit to wuchong/flink that referenced this pull request May 13, 2020
@wuchong
[FLINK-17538][hbase] Refactor flink-hbase connector structure
8b515c1 
(1) rename flink-hbase module to flink-connector-hbase
(2) Move interfaces and classes to org.apache.flink.connector.hbase
(3) Keep ancient TableInputFormat in old package and mark deprecated
(4) Restructure classes into sub-packages
(5) Update documentations

This closes apache#12102
@wuchong
[FLINK-17538][hbase] Refactor flink-hbase connector structure
f6797b1 
(1) rename flink-hbase module to flink-connector-hbase
(2) Move interfaces and classes to org.apache.flink.connector.hbase
(3) Keep ancient TableInputFormat in old package and mark deprecated
(4) Restructure classes into sub-packages
(5) Update documentations

This closes apache#12102
@wuchong
Copy link
Member Author

wuchong commented May 14, 2020

Tests are passed in my Azure: https://dev.azure.com/imjark/Flink/_build/results?buildId=76&view=results

Except the KafkaProducerExactlyOnceITCase.testMultipleSinkOperators is failed which is tracked by FLINK-16383.

@wuchong wuchong merged commit 360abcc into apache:master May 14, 2020
@wuchong wuchong deleted the hbase-refactor branch May 14, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees

No one assigned

Labels

component=Connectors/HBase review=description?

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wuchong @flinkbot @JingsongLi @rmetzger