[FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…

[cshuo]

…es wrong plan when there exist distinct agg and simple agg with same filter.

What is the purpose of the change

DecomposeGroupingSetsRule may generates wrong plan when there exist distinct agg and simple agg with same filter, such as the following example:

SELECT
   h,
   COUNT(1) FILTER(WHERE d > 1),
   COUNT(DISTINCT e) FILTER(WHERE d > 1)
FROM Table5
GROUP BY h

Brief change log

• This PR fix bugs in DecomposeGroupingSetsRule.

Verifying this change

This change added tests:

• Add integration test in AggregateITCaseBase for end-to-end test.
• Add unit test in DistinctAggregateTestBase.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)

[cshuo]

@godfreyhe @JingsongLi It's appreciated if you can have a look.

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f25b566 (Mon May 18 03:11:11 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!
• This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• f25b566 Azure: FAILURE
• 4124016 Azure: PENDING

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[cshuo]

@flinkbot run azure

[godfreyhe]

Thanks for the fix @cshuo , LGTM

[JingsongLi]

Thanks @cshuo for contribution, looks good to me.