[FLINK-17842][network] Fix performance regression in SpanningWrapper#clear#12267
Merged
pnowojski merged 1 commit intoapache:masterfrom May 21, 2020
Merged
[FLINK-17842][network] Fix performance regression in SpanningWrapper#clear#12267pnowojski merged 1 commit intoapache:masterfrom
pnowojski merged 1 commit intoapache:masterfrom
Conversation
…clear For some reason the following commit: 5415574 [FLINK-17547][task] Use RefCountedFile in SpanningWrapper caused a performance regression in various benchmarks. It's hard to tell why as none of the benchmarks are using spill files (records are too small), so our best guess is that combination of AtomicInteger inside RefCountedFile plus NullPointerException handling messed up with JIT ability to get rid of the memory barrier (from AtomicInteger) on the hot path.
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 0afb379 (Fri Oct 16 10:53:25 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Collaborator
rkhachatryan
approved these changes
May 20, 2020
Contributor
rkhachatryan
left a comment
rkhachatryan
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for fixing this issue!
Contributor
|
just for the record, benchmark results (build 157): Build failure unrelated: https://issues.apache.org/jira/browse/FLINK-17817 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason the following commit:
5415574 [FLINK-17547][task] Use RefCountedFile in SpanningWrapper
caused a performance regression in various benchmarks. It's hard to tell why as none of the benchmarks are using spill files (records are too small), so our best guess is that combination of AtomicInteger inside RefCountedFile plus NullPointerException handling messed up with JIT ability to get rid of the memory barrier (from AtomicInteger) on the hot path.
Verifying this change
This change is covered by existing micro benchmarks.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation