Skip to content

[FLINK-15620] Remove deprecated enable default background cleanup #12304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jiayi-Liao wants to merge 1 commit into from
Closed

[FLINK-15620] Remove deprecated enable default background cleanup #12304

Jiayi-Liao wants to merge 1 commit into from

Conversation

@Jiayi-Liao
Copy link
Contributor

@Jiayi-Liao Jiayi-Liao commented May 24, 2020

What is the purpose of the change

Follow-up for FLINK-15620. Remove deprecated cleanupInBackground in StateTtlConfig.

Brief change log

Remove deprecated cleanupInBackground in StateTtlConfig.

Verifying this change

This should be covered by existing unit testing.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes but already deprecated since release 1.10
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented May 24, 2020 •
edited
Loading

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3e369cb (Fri Oct 16 10:55:25 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented May 24, 2020 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@Jiayi-Liao Jiayi-Liao mentioned this pull request May 25, 2020
Merged
klion26
klion26 reviewed May 25, 2020
View reviewed changes
Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jiayi-Liao thanks for your contribution, left some minor comments

...tebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java Outdated
.withDescription("This determines if compaction filter to cleanup state with TTL is enabled for backend. " +
"Note: User can still decide in state TTL configuration in state descriptor " +
"whether the filter is active for particular state or not.");

Copy link
Member

@klion26 klion26 May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should revert such change.

flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java Outdated
* It means that the TTL filter should be tested for List state taking into account this caveat.
*
* @deprecated Use more general configuration method {@link #cleanupInBackground()} instead
* @deprecated
Copy link
Member

@klion26 klion26 May 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we introduced cleanupInBackground to deprecate the function cleanupInRocksdbCompactFilter, now, we removed cleanupInBackground, do we need to remove the function cleanupInRocksdbCompactFilter also?

Copy link
Contributor

@azagrebin azagrebin May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be addressed in #12307.

@Jiayi-Liao
Copy link
Contributor Author

Jiayi-Liao commented May 25, 2020

@klion26 Thanks for your review. The CompactionFilter part is in #12307, which is rebased on this PR. I'll ping you after the CI pipeline succeeds.

@Jiayi-Liao
Copy link
Contributor Author

Jiayi-Liao commented May 25, 2020

@klion26 Thanks for your review. The CompactionFilter part is in #12307, which is rebased on this PR. I'll ping you after the CI pipeline succeeds.

kindly ping @klion26

azagrebin
azagrebin approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@azagrebin azagrebin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Jiayi-Liao , LGTM
I will address the minor comments while merging it.

flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java Outdated
* It means that the TTL filter should be tested for List state taking into account this caveat.
*
* @deprecated Use more general configuration method {@link #cleanupInBackground()} instead
* @deprecated
Copy link
Contributor

@azagrebin azagrebin May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @deprecated
* @deprecated Use more general configuration method {@link #cleanupInRocksdbCompactFilter(long)} instead

@azagrebin azagrebin force-pushed the FLINK-15620-remove-deprecated branch from 89a2001 to 52eef3b Compare May 26, 2020 08:03
@azagrebin azagrebin force-pushed the FLINK-15620-remove-deprecated branch from 52eef3b to 3e369cb Compare May 26, 2020 08:04
@azagrebin azagrebin closed this in 8b1e747 May 26, 2020
azagrebin pushed a commit that referenced this pull request May 26, 2020
@azagrebin
[FLINK-15620][state][TTL] Remove deprecated enable default background…
54ecdc2 
… cleanup

This closes #12304.
@Jiayi-Liao Jiayi-Liao deleted the FLINK-15620-remove-deprecated branch May 26, 2020 08:10
zhangjun0x01 pushed a commit to zhangjun0x01/flink that referenced this pull request Jul 8, 2020
[FLINK-15620][state][TTL] Remove deprecated enable default background…
9b558a0 
… cleanup

This closes apache#12304.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klion26 klion26 klion26 left review comments

@azagrebin azagrebin azagrebin approved these changes

Assignees

No one assigned

Labels

component=Runtime/StateBackends review=description?

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Jiayi-Liao @flinkbot @klion26 @azagrebin @rmetzger