[FLINK-17756][table-api-java] Drop table/view shouldn't take effect o… #12314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 6d0fcab (Fri Oct 16 10:56:21 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
JingsongLi
reviewed
May 25, 2020
| return; | ||
| } | ||
| } | ||
| execute( |
Contributor
There was a problem hiding this comment.
Can you move this execute into if (filter.test(result.getTable()))?
JingsongLi
reviewed
May 25, 2020
| ObjectIdentifier objectIdentifier, | ||
| Predicate<CatalogBaseTable> filter, | ||
| boolean ignoreIfNotExists) { | ||
| final Optional<TableLookupResult> resultOpt = getTable(objectIdentifier); |
Contributor
There was a problem hiding this comment.
Why not just getPermanentTable? You can keep previous temporaryTables.containsKey(objectIdentifier)
Collaborator
JingsongLi
pushed a commit
that referenced
this pull request
May 27, 2020
zhangjun0x01
pushed a commit
to zhangjun0x01/flink
that referenced
this pull request
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n each other
Throws exception when we drop table with object identifier that represents a view(and vice versa).