-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-17931] Document fromValues clause in Table API #12325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3db6b26 (Mon May 25 14:14:39 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
aljoscha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I had some slight comments about wording. I only commented on one part, the changes should of course be applied to all four parts the same way. Then it's good to merge.
| </td> | ||
| <td> | ||
| <p>Similar to the VALUES clause in a SQL query. Produces an inline table out of the provided rows.</p> | ||
| <p>You can use a `row(...)` expression to create a composite rows:</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <p>You can use a `row(...)` expression to create a composite rows:</p> | |
| <p>You can use a `row(...)` expression to create composite rows:</p> |
| |-- f1: VARCHAR(5) NOT NULL // original types CHAR(3) and CHAR(5) are generalized | ||
| // to VARCHAR(5). It uses VARCHAR instead of CHAR so that | ||
| // no padding is applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| |-- f1: VARCHAR(5) NOT NULL // original types CHAR(3) and CHAR(5) are generalized | |
| // to VARCHAR(5). It uses VARCHAR instead of CHAR so that | |
| // no padding is applied | |
| |-- f1: VARCHAR(5) NOT NULL // original types CHAR(3) and CHAR(5) are generalized | |
| // to VARCHAR(5). VARCHAR is used instead of CHAR so that | |
| // no padding is applied |
What is the purpose of the change
Add documentation on the
fromValuesclause.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation