[FLINK-13632] Port serializer upgrade tests to TypeSerializerUpgradeTestBase #12363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We change MIGRATION_VERSIONS to only test versions > 1.11 because that's when we're adding the tests. We make an exception for PojoSerializerUpgradeTest and RowSerializerUpgradeTest, for which we have earlier snapshots. This also changes the test base to only generate snapshots for the CURRENT_VERSION when we generateTestSetupFiles().
Theses snapshots were created on the release-1.11 branch by un-@Ignoring TypeSerializerUpgradeTestBase.generateTestSetupFiles() and running tests on each subclass individually.
…erUpgradeTestBase
…izerUpgradeTestBase
…TypeSerializerUpgradeTestBase
…erUpgradeTestBase
… to TypeSerializerUpgradeTestBase
…zerUpgradeTestBase
…lizerUpgradeTestBase
…erUpgradeTestBase
All tests have been ported to the new test base.
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit b2da3dd (Wed May 27 14:57:47 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Collaborator
klion26
reviewed
May 28, 2020
| testVersions.add(MigrationVersion.v1_7); | ||
| testVersions.add(MigrationVersion.v1_8); | ||
| testVersions.add(MigrationVersion.v1_9); | ||
| testVersions.addAll(Arrays.asList(MIGRATION_VERSIONS)); |
Member
There was a problem hiding this comment.
IICU, we do not support v1_10 here because of there did not have the snapshot for 1_10, do we need to add a comment for this.
Contributor
Author
There was a problem hiding this comment.
You're right, I'm extending the comment here.
Contributor
Author
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
We migrate all serializer upgrade tests from
TypeSerializerSnapshotMigrationTestBasetoTypeSerializerUpgradeTestBase. Additionally, we add snapshots for Flink 1.11 for all the serializers. This will give us test coverage from 1.11 onward for serializer compatibility.This is work by @klion26 and me, I am mostly the reviewer but putting up this PR to have a paper trail.
And thanks a lot to @klion26 for working on this gigantic task with me! 🎊
Brief change log
MigrationVersioncc @klion26 Could you do a final review?
cc @tzulitai