[FLINK-18075] Call open method of SerializationSchema in Kafka producer

[dawidwys]

What is the purpose of the change

The open method of SerializationSchema was not called in the universal
Kafka producer.

Verifying this change

I verified it by writing records to Kafka using KafkaDynamicTableSink and AvroRowDataSerializationSchema which initializes its state in the open method.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[dawidwys]

cc @aljoscha @sjwiesman

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 56691cd (Tue Jun 02 21:33:59 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• 56691cd Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[sjwiesman]

LGTM, +1 on green

[wuchong]

Looks good to me too.

I will merge this because the fix of FLINK-18073 also depends on this.

[dawidwys]

Please do not. We decided with @aljoscha to take a different approach

[wuchong]

Oh.. Sorry, should I revert this? @dawidwys

[dawidwys]

Nah, I don't think it makes sense. It is not wrong what you merged. I will create a PR on top of it.

[wuchong]

Thanks @dawidwys and sorry again for the trouble.

[dawidwys]

No worries, everything's fine.