Skip to content

[FLINK-13783][table] Implement type inference for string functions#12593

Closed
twalthr wants to merge 1 commit intoapache:masterfrom
twalthr:FLINK-13783
Closed

[FLINK-13783][table] Implement type inference for string functions#12593
twalthr wants to merge 1 commit intoapache:masterfrom
twalthr:FLINK-13783

Conversation

@twalthr
Copy link
Copy Markdown
Contributor

@twalthr twalthr commented Jun 11, 2020

What is the purpose of the change

Updates the expressions:

CHAR_LENGTH
LIKE
LOWER
LOWERCASE
UPPER
UPPERCASE
INIT_CAP
RPAD
LPAD
RTRIM
LTRIM
SUBSTRING
CONCAT
CONCAT_WS
SHA1
SHA2
SHA224
SHA256
SHA384
SHA512
REPEAT
REPLACE
TO_BASE64
FROM_BASE64
POSITION
MD5
REGEXP_EXTRACT
REGEXP_REPLACE
SIMILAR
TRIM

Brief change log

  • Expressions updated
  • Old planner expressions removed

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit e3197af (Thu Jun 11 07:15:14 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Jun 11, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@dawidwys dawidwys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

final LogicalType type1 = argumentDataTypes.get(0).getLogicalType();
final LogicalType type2 = argumentDataTypes.get(1).getLogicalType();
int length = getLength(type1) + getLength(type2);
if (length < 0) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a comment //overflow

@twalthr twalthr closed this in 6e688e1 Jun 15, 2020
bigdata-ny pushed a commit to bigdata-ny/flink that referenced this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants