[FLINK-17789][API/Core] DelegatingConfiguration should remove prefix …

[pyscala]

What is the purpose of the change

1.DelegatingConfiguration should remove prefix instead of add prefix in toMap
2.Make toMap consistent with addAllToProperties in class DelegatingConfiguration

Brief change log

1.DelegatingConfiguration should remove prefix instead of add prefix in toMap
2.Make toMap consistent with addAllToProperties in class DelegatingConfiguration

Verifying this change

This change added tests and can be verified as follows:
unit test testDelegationConfigurationToMapConsistentWithAddAllToProperties in class DelegatingConfigurationTest

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): ( no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? ( no)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c9e05d7 (Wed Jul 15 11:11:37 UTC 2020)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!
• This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[pyscala]

Hi @JingsongLi , Looking forward to your review, thanks.

[flinkbot]

CI report:

• a841105 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build
• @flinkbot run azure re-run the last Azure build

[pyscala]

Hi @zentol , Thanks for your commits. Can you review this PR for us ?

[JingsongLi]

Thanks @pyscala for your contribution. Changes looks good to me overall. But I want to hear from @zentol

[pyscala]

Thanks @pyscala for your contribution. Changes looks good to me overall. But I want to hear from @zentol

Thanks @JingsongLi for your reply.

[zentol]

Probably fine.
I thought that changing this would break something for the formats, but tests are passing and I cannot find where I draw this conclusion from.

[JingsongLi]

@flinkbot run azure

[JingsongLi]

@pyscala Can you rebase for triggering testing?

[pyscala]

@pyscala Can you rebase for triggering testing?

@JingsongLi I will do it later

[pyscala]

Hi @JingsongLi
Current error seems to have nothing to do with our changes.
Looking forward to your reply , thanks

[zentol]

@pyscala You haven't rebase on the latest master, and are about a week behind.

[pyscala]

Hi @JingsongLi @zentol Thanks for detailed reply. is this OK ? Or I close this PR and create a new one ?

[JingsongLi]

@pyscala You can squash your commits, and cherry-pick to latest master, then replace your FLINK-17789 branch. And force push to your FLINK-17789 branch.

[pyscala]

Hi @JingsongLi @zentol Done, Everything looks good

[JingsongLi]

Thanks @pyscala for your updating. Looks good to me.
Merging...