Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Jul 21, 2020

Fixes an issue where a task would be canceled if a task executor reported the execution via heartbeats without the acknowledgement yet being processed by the JobMaster. This can happen because the Acknowledge was lost, or due to message re-ordering on the JobMaster side.

The ExecutionDeployment(Tracker/Reconciler) now distinguish between PENDING/DEPLOYED executions.
For reconciliation purposes executions in a PENDING state are ignored.
Executions are moved into a deployed state once the acknowledge by the TaskExecutor has been processed by the JobMaster.
If the task is never acknowledged, then, as before, the task is failed by the JobMaster, and then removed from the tracker (due to terminal state transition, as before).

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f681caa (Tue Jul 21 12:03:44 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 21, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zentol. The changes look good to me. +1 for merging.

@zentol zentol merged commit 11663f5 into apache:master Jul 23, 2020
@zentol zentol deleted the 18533 branch September 29, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants