-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-18493][Deployment / YARN]Make target home directory used to store yarn files configurable #13014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 4e331d3 (Wed Jul 29 07:07:58 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
@flinkbot run travis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for creating this PR @KevinZwx. The changes look good to me. I had to comments which I will address myself while merging this PR. I've also tested this feature and it seemed to work.
As a side note for the future, the Flink community does not use merge commits. Instead, we rebase the changes on top of the current master before merging it.
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
Outdated
Show resolved
Hide resolved
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
Outdated
Show resolved
Hide resolved
e373828 to
39986b5
Compare
|
Thanks @tillrohrmann for reviewing and fixing the code |
What is the purpose of the change
When submitting applications to yarn, the file system's default home directory, like /user/user_name on hdfs, is used as the base directory to store flink files. But in different file system access control strategies, the default home directory may be inaccessible, and it's more preferable for users to specify thier own paths if they wish to.
Brief change log
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation