-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-18773][runtime] Enables parallel user-code and plugin class loader. #13031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit eda9fa6 (Thu Jul 30 13:34:00 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
zentol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, had one question for clarity.
| } | ||
|
|
||
| if (resolve) { | ||
| } else if (resolve) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this change about?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a small performance optimization (should probably go in a separate hotfix commit). The typical class loading pattern indeed has this trailing resolution with an if, but in ChildFirstClassLoader, the resolution already happens at super.loadClassWithoutExceptionHandling(name, resolve). So it should never be necessary to resolve it additionally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that makes sense, let's move it into another commit and then we're good to merge.
…assLoader. Classes that also need to loaded are already resolved through super.loadClassWithoutExceptionHandling(name, resolve).
What is the purpose of the change
Enables parallel user-code and plugin class loader.
Brief change log
Verifying this change
No new test (test ideas welcome), covered by all IT and e2e tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation