Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Aug 3, 2020

The ConfigDocsGenerator no longer creates files that do not contain any options.

This can happen if some class matches the naming pattern we use, but doesn't actually contain options, or if config groups aren't matching any options.

This PR also includes some cleanup hotfixes; sorting entries and pruning unused files.

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 3, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 63bfa99 (Mon Aug 03 11:49:16 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 3, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No remarks on the code. 👍 Building the docs resulted in a modified version of docs/_includes/generated/yarn_config_configuration.html, though. This might be caused by me having a more recent snapshot installed in my local repository for the YARN configuration.

@zentol zentol merged commit cb0247b into apache:master Aug 5, 2020
@zentol zentol deleted the 18804 branch September 29, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants