Skip to content

[FLINK-2934] Remove placeholder pages for job.statistics, taskmanager.log and taskmanager.stdout #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sachingoel0101 wants to merge 1 commit into from
Closed

[FLINK-2934] Remove placeholder pages for job.statistics, taskmanager.log and taskmanager.stdout #1307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions flink-runtime-web/web-dashboard/app/partials/jobs/job.jade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main-additional(ng-if="job")
li(ui-sref-active='active')
a(ui-sref=".plan.overview") Plan

li(ui-sref-active='active')
a(ui-sref=".statistics") Job Accumulators / Statistics

//- li(ui-sref-active='active' ng-if="job['end-time'] > -1")
li(ui-sref-active='active')
a(ui-sref=".timeline") Timeline
Expand Down
35 changes: 0 additions & 35 deletions flink-runtime-web/web-dashboard/app/partials/jobs/job.statistics.jade
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions flink-runtime-web/web-dashboard/app/partials/taskmanager/taskmanager.jade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,6 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main-additional(ng-if="metrics
li(ui-sref-active='active')
a(ui-sref=".metrics") Metrics

li(ui-sref-active='active')
a(ui-sref=".log") Logs

li(ui-sref-active='active')
a(ui-sref=".stdout") Stdout


#content-inner.has-navbar-main-additional
div(ui-view="details")

17 changes: 0 additions & 17 deletions flink-runtime-web/web-dashboard/app/partials/taskmanager/taskmanager.logfile.jade
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions flink-runtime-web/web-dashboard/app/partials/taskmanager/taskmanager.stdout.jade
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions flink-runtime-web/web-dashboard/app/scripts/index.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,12 +197,6 @@ angular.module('flinkApp', ['ui.router', 'angularMoment'])
templateUrl: "partials/jobs/job.timeline.vertex.html"
controller: 'JobTimelineVertexController'

.state "single-job.statistics",
url: "/statistics"
views:
details:
templateUrl: "partials/jobs/job.statistics.html"

.state "single-job.exceptions",
url: "/exceptions"
views:
Expand Down Expand Up @@ -243,18 +237,6 @@ angular.module('flinkApp', ['ui.router', 'angularMoment'])
details:
templateUrl: "partials/taskmanager/taskmanager.metrics.html"

.state "single-manager.log",
url: "/logfile"
views:
details:
templateUrl: "partials/taskmanager/taskmanager.logfile.html"

.state "single-manager.stdout",
url: "/stdout"
views:
details:
templateUrl: "partials/taskmanager/taskmanager.stdout.html"

.state "jobmanager",
url: "/jobmanager"
views:
Expand Down
23 changes: 1 addition & 22 deletions flink-runtime-web/web-dashboard/web/js/index.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion flink-runtime-web/web-dashboard/web/partials/jobs/job.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
<nav ng-if="job" class="navbar navbar-default navbar-fixed-top navbar-main-additional">
<ul class="nav nav-tabs">
<li ui-sref-active="active"><a ui-sref=".plan.overview">Plan</a></li>
<li ui-sref-active="active"><a ui-sref=".statistics">Job Accumulators / Statistics</a></li>
<li ui-sref-active="active"><a ui-sref=".timeline">Timeline</a></li>
<li ui-sref-active="active"><a ui-sref=".exceptions">Exceptions</a></li>
<li ui-sref-active="active"><a ui-sref=".properties">Properties</a></li>
Expand Down
2 changes: 0 additions & 2 deletions flink-runtime-web/web-dashboard/web/partials/taskmanager/taskmanager.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
<nav ng-if="metrics.id" class="navbar navbar-default navbar-fixed-top navbar-main-additional">
<ul class="nav nav-tabs">
<li ui-sref-active="active"><a ui-sref=".metrics">Metrics</a></li>
<li ui-sref-active="active"><a ui-sref=".log">Logs</a></li>
<li ui-sref-active="active"><a ui-sref=".stdout">Stdout</a></li>
</ul>
</nav>
<div id="content-inner" class="has-navbar-main-additional">
Expand Down