Skip to content

Conversation

@RocMarshal
Copy link
Contributor

What is the purpose of the change

Translate the 'History Server' page of 'Debugging & Monitoring' into Chinese

Brief change log

Translate the 'History Server' page of 'Debugging & Monitoring' into Chinese

Verifying this change

This change is a pure documentation translation.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d6b806b (Fri Aug 21 06:26:19 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 21, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@RocMarshal RocMarshal marked this pull request as ready for review August 22, 2020 06:05
@RocMarshal
Copy link
Contributor Author

@flinkbot run azure

@RocMarshal
Copy link
Contributor Author

Hi @klion26
Could you help me to review this PR if you have free time?
Thank you.

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RocMarshal thanks for your contribution, left some comments. please let me know what do you think, thanks.

@RocMarshal
Copy link
Contributor Author

RocMarshal commented Aug 26, 2020

@klion26
Thank you very much for your guidance and advices. I made some adjustments according to your suggestions.
If you have free time, please have a look. Looking forward to your further suggestions.

Copy link
Member

@klion26 klion26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RocMarshal thanks for addressing the comments. LGTM now
ping @wuchong @rmetzger

@wuchong
Copy link
Member

wuchong commented Aug 27, 2020

Merging...

@wuchong wuchong merged commit 6be3514 into apache:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants