[FLINK-19188][examples-table] Add a new streaming SQL example #13413

twalthr · 2020-09-17T14:47:33Z

What is the purpose of the change

Example for aggregating and ranking data using Flink SQL on updating (but bounded) streams.

This PR depends on #13291.

Brief change log

The example shows how to declare a table using SQL DDL for reading insert-only data and handling
updating data. It should give a first impression about Flink SQL as a changelog processor. The example
uses some streaming operations that produce a stream of updates. See the other examples for pure CDC
processing and more complex operations.

Verifying this change

This change added tests and can be verified as follows: UpdatingTopCityExample

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): yes
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

… wrong result The batch mode rank only supports RANK function, so we only rewrite the stream mode query.

flinkbot · 2020-09-17T14:49:48Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 4ccc07b (Fri May 28 06:58:32 UTC 2021)

Warnings:

1 pom.xml files were touched: Check for build and licensing issues.
No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2020-09-17T15:17:07Z

CI report:

4ccc07b Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

dawidwys

Nice work!

+1 to merge, (after #13291 is merged, ofc ;) )

dawidwys · 2020-09-18T12:29:40Z

...-table/src/main/java/org/apache/flink/table/examples/java/basics/UpdatingTopCityExample.java

+import java.util.List;
+
+/**
+ * Example for aggregating and ranking data using Flink SQL on updating (but bounded) streams.


nit: Is the (but bounded) note necessary or important for the example? Just wondering if it helps users understand the use case/example or introduces unnecessary distraction/additional concept to understand.

dawidwys · 2020-09-18T12:50:57Z

...-table/src/main/java/org/apache/flink/table/examples/java/basics/UpdatingTopCityExample.java

+		);
+
+		// since all cluster operations of the Table API are executed asynchronously,
+		// we need wait until the insertion has been completed,


Suggested change

// we need wait until the insertion has been completed,

// we need to wait until the insertion has been completed,

twalthr · 2020-11-24T11:05:29Z

@rmetzger Do we consider examples as features? This PR is laying around for quite some time and was blocked by a bug that will be fixed soon. The Table/SQL API lacks new updated examples.

rmetzger · 2020-11-24T12:32:06Z

I think examples are comparable to documentation. I still would be careful if an example changes a lot of dependencies.

In this case I'm fine with merging it.

cshuo · 2020-12-30T08:43:53Z

...-table/src/main/java/org/apache/flink/table/examples/java/basics/UpdatingTopCityExample.java

+				final RowKind kind = row.getKind();
+				switch (kind) {
+					case INSERT:
+					case UPDATE_BEFORE:


Here should be UPDATE_AFTER

cshuo · 2020-12-30T08:44:03Z

...-table/src/main/java/org/apache/flink/table/examples/java/basics/UpdatingTopCityExample.java

+						row.setKind(RowKind.INSERT); // for equality
+						materializedUpdates.add(row);
+						break;
+					case UPDATE_AFTER:


Here should be UPDATE_BEFORE

danny0405 and others added 2 commits September 17, 2020 16:01

[FLINK-18988][table] Continuous query with LATERAL and LIMIT produces…

236fda3

… wrong result The batch mode rank only supports RANK function, so we only rewrite the stream mode query.

[FLINK-19188][examples-table] Add a new streaming SQL example

4ccc07b

twalthr changed the title ~~Flink 19188~~ [FLINK-19188][examples-table] Add a new streaming SQL example Sep 17, 2020

rmetzger added the review=description? label Sep 17, 2020

rmetzger added the component=TableSQL/API label Sep 17, 2020

dawidwys self-assigned this Sep 18, 2020

dawidwys reviewed Sep 18, 2020

View reviewed changes

dawidwys approved these changes Sep 18, 2020

View reviewed changes

twalthr closed this in e4286e7 Nov 24, 2020

cshuo reviewed Dec 30, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FLINK-19188][examples-table] Add a new streaming SQL example #13413

[FLINK-19188][examples-table] Add a new streaming SQL example #13413

Uh oh!

twalthr commented Sep 17, 2020

Uh oh!

flinkbot commented Sep 17, 2020 •

edited

Loading

Uh oh!

flinkbot commented Sep 17, 2020 •

edited

Loading

Uh oh!

dawidwys left a comment •

edited

Loading

Uh oh!

dawidwys Sep 18, 2020

Uh oh!

dawidwys Sep 18, 2020

Uh oh!

twalthr commented Nov 24, 2020

Uh oh!

rmetzger commented Nov 24, 2020

Uh oh!

cshuo Dec 30, 2020

Uh oh!

cshuo Dec 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	// we need wait until the insertion has been completed,
	// we need to wait until the insertion has been completed,

[FLINK-19188][examples-table] Add a new streaming SQL example #13413

[FLINK-19188][examples-table] Add a new streaming SQL example #13413

Uh oh!

Conversation

twalthr commented Sep 17, 2020

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

Uh oh!

flinkbot commented Sep 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automated Checks

Review Progress

Uh oh!

flinkbot commented Sep 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI report:

Uh oh!

dawidwys left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dawidwys Sep 18, 2020

Choose a reason for hiding this comment

Uh oh!

dawidwys Sep 18, 2020

Choose a reason for hiding this comment

Uh oh!

twalthr commented Nov 24, 2020

Uh oh!

rmetzger commented Nov 24, 2020

Uh oh!

cshuo Dec 30, 2020

Choose a reason for hiding this comment

Uh oh!

cshuo Dec 30, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

flinkbot commented Sep 17, 2020 •

edited

Loading

flinkbot commented Sep 17, 2020 •

edited

Loading

dawidwys left a comment •

edited

Loading