-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[hotfix] Log interrupted exception on debug when closing threads in ExternalSorter #13668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 0602dad (Fri Oct 16 15:34:17 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
rmetzger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for a tiny naming problem, this is good to go.
| } | ||
| } | ||
|
|
||
| private void closeThread(StageRunner sortThread, String threadName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| private void closeThread(StageRunner sortThread, String threadName) { | |
| private void closeThread(StageRunner thread, String threadName) { |
|
|
||
| private void closeThread(StageRunner sortThread, String threadName) { | ||
| try { | ||
| sortThread.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| sortThread.close(); | |
| thread.close(); |
0602dad to
8e1a084
Compare
What is the purpose of the change
Revert the behaviour of logging an InterreputedException on debug level when closing working threads in ExternalSorter.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation