Skip to content

Conversation

@wangxlong
Copy link
Contributor

@wangxlong wangxlong commented Oct 20, 2020

What is the purpose of the change

Fix the banned dependencies failed for 'flink-sql-connector-hive-2.3.6'.

The error message,
Rule 0: org.apache.maven.plugins.enforcer.BannedDependencies failed with message: Found Banned Dependency: org.apache.kafka:kafka_2.10:jar:0.10.2.0 Use 'mvn dependency:tree' to locate the source of the banned dependencies.

For root pom has a rule as follow,

<bannedDependencies>
<excludes combine.children="append">
<exclude>*:*_2.12</exclude>
<exclude>*:*_2.10</exclude>
</excludes>
</bannedDependencies>

Which forces scala_2.11 version, but this module contains kafka_2.10.

Brief change log

Exclude dependency,
<exclusion>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka_2.10</artifactId>
</exclusion>
`

Verifying this change

After excluding, build correctl

@wangxlong
Copy link
Contributor Author

Hi @JingsongLi, Could you help to have a reivew, thanks.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9ca6467 (Tue Oct 20 02:34:01 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • Invalid pull request title: No valid Jira ID provided

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 20, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@wangxlong
Copy link
Contributor Author

Hi @wuchong @JingsongLi Could you help to have a look. It will lead to build Flink project fail locally, So It is better to have a fix.

@zentol
Copy link
Contributor

zentol commented Nov 11, 2022

No longer applicable.

@zentol zentol closed this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants