[FLINK-19232][python] support iterating MapState and MapView #13739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9f75014 (Thu Oct 22 05:01:49 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Collaborator
dianfu
reviewed
Oct 22, 2020
| } else { | ||
| iterator = mapStateIteratorCache.get(iteratorToken); | ||
| if (iterator == null) { | ||
| throw new RuntimeException("The cached iterator not exist!"); |
Contributor
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException("The cached iterator not exist!"); | |
| throw new RuntimeException("The cached iterator does not exist!"); |
| public static final ConfigOption<Integer> MAP_STATE_ITERATE_CACHE_SIZE = ConfigOptions | ||
| .key("python.map-state.iterate-cache-size") | ||
| .defaultValue(1000) | ||
| .withDescription("The maximum number of entries read from Java side when iterating a " + |
Contributor
There was a problem hiding this comment.
What about improving the doc a bit to make it more clear what this config option is used for?
| if self._underlying_is_write_cache: | ||
| # Iterate the data in write cache firstly | ||
| try: | ||
| key, existed_and_value = next(self._underlying) |
Contributor
There was a problem hiding this comment.
Suggested change
| key, existed_and_value = next(self._underlying) | |
| self._last_key, (exists, value) = next(self._underlying) |
| # cache. | ||
| if self._internal_map_state._cleared: | ||
| del self._internal_map_state._write_cache[self._last_key] | ||
| self._mod_count += 1 |
Contributor
There was a problem hiding this comment.
Could refactor a bit to remove the duplicate code
| self._write_cache.clear() | ||
| self._cleared = False | ||
|
|
||
| def _iterate_next_batch(self, iterate_type, iterator_token): |
Contributor
There was a problem hiding this comment.
Suggested change
| def _iterate_next_batch(self, iterate_type, iterator_token): | |
| def next_batch(self, iterate_type, iterator_token): |
| </tr> | ||
| <tr> | ||
| <td><h5>python.map-state.read.cache.size</h5></td> | ||
| <td><h5>python.map-state.iterate-cache-size</h5></td> |
Contributor
There was a problem hiding this comment.
python.map-state.iterate-req-batch-size
WeiZhong94
force-pushed
the
FINK-19232-iterate
branch
from
9f75014 to
844e71b
Compare
Contributor
Author
|
@dianfu Thanks for your comments! I have updated this PR. |
dianfu
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request supports iterating MapState and MapView
Brief change log
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation