-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-19923][coordination] Remove unused BulkSlotProvider, its implementation and tests #13877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit a05a2eb (Mon Nov 02 09:57:24 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
…mentation and tests BulkSlotProvider and its implementation (apache#12375) is not used any more because it was introduced for the removed OneSlotPerExecutionSlotAllocator (apache#12256) replaced by SlotSharingExecutionSlotAllocator (apache#13071) for the PipelinedRegionSchedulingStrategy. This closes apache#13877.
a05a2eb to
9f0b65d
Compare
zhuzhurk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
XComp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The PhysicalSlotProviderImplTest contains to tests testBulkSlotAllocationFulfilledWithAvailableSlots and testBulkSlotAllocationFulfilledWithNewSlots which I stumbled upon just because of them including "bulkslot". But this is completely unrelated, is it?
…sicalSlotProviderImplTest
BulkSlotProviderand its implementation (#12375) is not used any more because it was introduced for the removedOneSlotPerExecutionSlotAllocator(#12256) replaced bySlotSharingExecutionSlotAllocator(#13071) for the PipelinedRegionSchedulingStrategy.The PR removes the dead code.