Skip to content

Conversation

@azagrebin
Copy link
Contributor

BulkSlotProvider and its implementation (#12375) is not used any more because it was introduced for the removed OneSlotPerExecutionSlotAllocator (#12256) replaced by SlotSharingExecutionSlotAllocator (#13071) for the PipelinedRegionSchedulingStrategy.

The PR removes the dead code.

@azagrebin azagrebin requested a review from zhuzhurk November 2, 2020 09:54
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 2, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a05a2eb (Mon Nov 02 09:57:24 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 2, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

…mentation and tests

BulkSlotProvider and its implementation (apache#12375) is not used any more
because it was introduced for the removed OneSlotPerExecutionSlotAllocator (apache#12256)
replaced by SlotSharingExecutionSlotAllocator (apache#13071) for the PipelinedRegionSchedulingStrategy.

This closes apache#13877.
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The PhysicalSlotProviderImplTest contains to tests testBulkSlotAllocationFulfilledWithAvailableSlots and testBulkSlotAllocationFulfilledWithNewSlots which I stumbled upon just because of them including "bulkslot". But this is completely unrelated, is it?

@azagrebin
Copy link
Contributor Author

azagrebin commented Nov 3, 2020

Thanks for the review @zhuzhurk @XComp

@XComp the tests in PhysicalSlotProviderImplTest are indeed unrelated but there is no Bulk in there as well. It is a confusing leftover and I added a hotfix commit to remove it from test names.

@azagrebin azagrebin closed this in 86b3c71 Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants