[FLINK-19833] Rename Sink API Writer interface to SinkWriter#13887
Closed
guoweiM wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-19833] Rename Sink API Writer interface to SinkWriter#13887guoweiM wants to merge 1 commit intoapache:masterfrom
guoweiM wants to merge 1 commit intoapache:masterfrom
Conversation
This makes it more consistent with SourceReader.
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9d5d7fb (Mon Nov 02 13:55:57 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Collaborator
kl0u
approved these changes
Nov 2, 2020
Contributor
kl0u
left a comment
There was a problem hiding this comment.
LGTM! I will also let it run on AZP to be sure and then merge.
kl0u
pushed a commit
to kl0u/flink
that referenced
this pull request
Nov 3, 2020
This makes it more consistent with SourceReader. This closes apache#13887.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This makes it more consistent with SourceReader.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation