Skip to content

[FLINK-19833] Rename Sink API Writer interface to SinkWriter#13887

Closed
guoweiM wants to merge 1 commit intoapache:masterfrom
guoweiM:FLINK-19833
Closed

[FLINK-19833] Rename Sink API Writer interface to SinkWriter#13887
guoweiM wants to merge 1 commit intoapache:masterfrom
guoweiM:FLINK-19833

Conversation

@guoweiM
Copy link
Copy Markdown
Contributor

@guoweiM guoweiM commented Nov 2, 2020

What is the purpose of the change

This makes it more consistent with SourceReader.

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

This makes it more consistent with SourceReader.
@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Nov 2, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9d5d7fb (Mon Nov 02 13:55:57 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Nov 2, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@kl0u kl0u self-assigned this Nov 2, 2020
Copy link
Copy Markdown
Contributor

@kl0u kl0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I will also let it run on AZP to be sure and then merge.

kl0u pushed a commit to kl0u/flink that referenced this pull request Nov 3, 2020
This makes it more consistent with SourceReader.

This closes apache#13887.
@kl0u kl0u closed this in 34d0a9c Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants