Skip to content

[FLINK-19953] Translation in docs/ops/memory/mem_setup.zh.md#13923

Closed
Shawn-Hx wants to merge 2 commits intoapache:masterfrom
Shawn-Hx:FLINK-19953
Closed

[FLINK-19953] Translation in docs/ops/memory/mem_setup.zh.md#13923
Shawn-Hx wants to merge 2 commits intoapache:masterfrom
Shawn-Hx:FLINK-19953

Conversation

@Shawn-Hx
Copy link
Copy Markdown
Contributor

@Shawn-Hx Shawn-Hx commented Nov 4, 2020

What is the purpose of the change

Translate docs/ops/memory/mem_setup.zh.md according to FLINK-19904

Brief change log

  • Translate the new sentence.
  • Change link format

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Nov 4, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f0918c0 (Wed Nov 04 07:45:50 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Nov 4, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@XComp
Copy link
Copy Markdown
Contributor

XComp commented Nov 4, 2020

Thanks for the translation @Shawn-Hx. @xintongsong could you review the changes as you also did most of the translations in this file?

Copy link
Copy Markdown
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XComp Thanks for pulling me in.

@Shawn-Hx Thanks for the PR. The translation and link updates LGTM. I have only two minor comments:

  • The link format updates and the translation should be in two different commits.
  • The commit message should also contain the component that is being changed. For this case, [doc-zh].

I'll take over from here and address my comments while merging.

@xintongsong
Copy link
Copy Markdown
Contributor

Closed via b88859f

@xintongsong xintongsong closed this Nov 5, 2020
@Shawn-Hx Shawn-Hx deleted the FLINK-19953 branch November 5, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants