-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-19993] Remove flink-connector-filesystem module #13941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Still waiting for AZP to give the green light. |
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 88b2da1 (Thu Nov 05 09:55:27 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
88b2da1 to
5cba300
Compare
|
@flinkbot run azure |
dawidwys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the PR once azure gives green. Had just one minor comment.
| run_test "Batch SQL end-to-end test" "$END_TO_END_DIR/test-scripts/test_batch_sql.sh" | ||
| run_test "Streaming SQL end-to-end test (Old planner)" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh old" "skip_check_exceptions" | ||
| run_test "Streaming SQL end-to-end test (Blink planner)" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh blink" "skip_check_exceptions" | ||
| # skip test if hadoop version is 2.4.1 (FLINK-16629) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the comment as well
|
Thanks for the review @dawidwys ! Merged |
What is the purpose of the change
The flink-connector-filesystem module contains (only) the deprecated BucketingSink. The BucketingSink. The sink is deprecated since FLINK 1.9 in favour of the relatively recently introduced StreamingFileSink.
For the sake of a clean and more manageable codebase, the community chose to remove it [1] after the discussion in [2].
[1]
https://lists.apache.org/thread.html/red2bc04c5d60a6a923ea499a49d7889d66661c31ac1987ea6d9a3fe5%40%3Cdev.flink.apache.org%3E
[2] https://lists.apache.org/thread.html/re24ceedc02402ac9a6ce1e07b690852320a265b081f416ebac543aaf%40%3Cuser.flink.apache.org%3E
Brief change log
Removed the module itself and wherever it appeared in the documentation.
Verifying this change
This change is a code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation