Skip to content

Conversation

@kl0u
Copy link
Contributor

@kl0u kl0u commented Nov 5, 2020

What is the purpose of the change

The flink-connector-filesystem module contains (only) the deprecated BucketingSink. The BucketingSink. The sink is deprecated since FLINK 1.9 in favour of the relatively recently introduced StreamingFileSink.

For the sake of a clean and more manageable codebase, the community chose to remove it [1] after the discussion in [2].

[1]
https://lists.apache.org/thread.html/red2bc04c5d60a6a923ea499a49d7889d66661c31ac1987ea6d9a3fe5%40%3Cdev.flink.apache.org%3E
[2] https://lists.apache.org/thread.html/re24ceedc02402ac9a6ce1e07b690852320a265b081f416ebac543aaf%40%3Cuser.flink.apache.org%3E

Brief change log

Removed the module itself and wherever it appeared in the documentation.

Verifying this change

This change is a code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@kl0u kl0u requested a review from alpinegizmo November 5, 2020 09:52
@kl0u
Copy link
Contributor Author

kl0u commented Nov 5, 2020

Still waiting for AZP to give the green light.

@kl0u kl0u requested review from aljoscha, dawidwys and zentol November 5, 2020 09:53
@dawidwys dawidwys self-assigned this Nov 5, 2020
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 5, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 88b2da1 (Thu Nov 05 09:55:27 UTC 2020)

Warnings:

  • 4 pom.xml files were touched: Check for build and licensing issues.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 5, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@kl0u kl0u force-pushed the remove-bucketing-sink branch from 88b2da1 to 5cba300 Compare November 5, 2020 14:16
@kl0u
Copy link
Contributor Author

kl0u commented Nov 5, 2020

@flinkbot run azure

Copy link
Contributor

@dawidwys dawidwys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the PR once azure gives green. Had just one minor comment.

run_test "Batch SQL end-to-end test" "$END_TO_END_DIR/test-scripts/test_batch_sql.sh"
run_test "Streaming SQL end-to-end test (Old planner)" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh old" "skip_check_exceptions"
run_test "Streaming SQL end-to-end test (Blink planner)" "$END_TO_END_DIR/test-scripts/test_streaming_sql.sh blink" "skip_check_exceptions"
# skip test if hadoop version is 2.4.1 (FLINK-16629)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comment as well

@kl0u kl0u closed this in eb05e50 Nov 5, 2020
@kl0u
Copy link
Contributor Author

kl0u commented Nov 5, 2020

Thanks for the review @dawidwys ! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants