Skip to content

Conversation

@carp84
Copy link
Member

@carp84 carp84 commented Nov 7, 2020

This is a mirror of #13688 which addresses the final review comments and squashes all necessary commits. Submitting a PR simply to trigger the pre-commit build and make sure nothing broken.

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 7, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 39cc0db (Sat Nov 07 15:21:22 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 7, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@carp84
Copy link
Member Author

carp84 commented Nov 8, 2020

@flinkbot run azure

@carp84
Copy link
Member Author

carp84 commented Nov 8, 2020

The pre-commit build with 39cc0db was failed due to FLINK-19882, rerun to get a green build.

@carp84
Copy link
Member Author

carp84 commented Nov 9, 2020

The latest Azure build failed due to FLINK-20052, and comparing the two builds we could make sure the failure is irrelative to changes here, thus I will merge the commits soon.

@rmetzger @dianfu JFYI (for 1.12.0 release).

@carp84
Copy link
Member Author

carp84 commented Nov 9, 2020

Merged via 93c6256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants