Skip to content

Conversation

@dianfu
Copy link
Contributor

@dianfu dianfu commented Nov 10, 2020

What is the purpose of the change

This pull request fixes the docs_404_check

Verifying this change

Verified in my personal azure pipeline that it takes effect:
Failed if there are broken links in the documentation: https://dev.azure.com/dianfu/Flink/_build/results?buildId=237&view=logs&j=64eb2d20-7d61-5c6d-9ae0-2f5940b1051d&t=36ef8439-438c-5ac6-2742-d7c6b595805a
Succeed based on #14009 which fixed the broken links: https://dev.azure.com/dianfu/Flink/_build/results?buildId=236&view=logs&j=64eb2d20-7d61-5c6d-9ae0-2f5940b1051d&t=36ef8439-438c-5ac6-2742-d7c6b595805a

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicableno)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c52d50a (Tue Nov 10 11:55:34 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Nov 10, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@sjwiesman
Copy link
Contributor

+1 thank you for addressing this. It doesn't look like there is a 1.12 branch yet so let's try and get this in. I suspect we'll be backporting a number of docs prs between now and the release.

@rmetzger
Copy link
Contributor

We've decided to fork off the "release-1.12" branch once master is considered fairly stable, to avoid this backporting all the time.

@rmetzger
Copy link
Contributor

Thanks a lot for this fix! Merging ...

@rmetzger rmetzger merged commit 3add52d into apache:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants