[FLINK-2954] Add config parameter for passing environment variables to YARN #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
I wonder about the naming here. Maybe this should be YARN_RESOURCE_MANAGER_ENV_PREFIX? Or change YARN_APPLICATION_MASTER_ENV_PREFIX to YARN_JOB_MANAGER_ENV_PREFIX?
Contributor
Author
There was a problem hiding this comment.
I think YARN_RESOURCE_MANAGER_ENV_PREFIX is wrong bc its a service of YARN, not of Flink (http://hortonworks.com/blog/apache-hadoop-yarn-resourcemanager/).
Whether to use AM or JM is a good question. In the YARN context, AM and JM are basically the same. I think AM is a bit more consistent.
Contributor
|
Looks good except for some minor issues. |
Contributor
Author
|
Thank you for the good review. I addressed some of your concerns. |
Contributor
Author
|
Thanks for the review. I'll merge it soon |
…o YARN This closes apache#1409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.