Skip to content

[FLINK-17424][e2e] Adopt download strategy of Kafka tests in Elasticsearch tests#14106

Closed
twalthr wants to merge 3 commits intoapache:masterfrom
twalthr:FLINK-17424
Closed

[FLINK-17424][e2e] Adopt download strategy of Kafka tests in Elasticsearch tests#14106
twalthr wants to merge 3 commits intoapache:masterfrom
twalthr:FLINK-17424

Conversation

@twalthr
Copy link
Copy Markdown
Contributor

@twalthr twalthr commented Nov 17, 2020

What is the purpose of the change

Adds some retry and timeout logic to the Elasticsearch binary download logic.

Additionally, it cleans up the testing matrix a bit to make the e2e tests quicker on Azure.

Brief change log

See commit messages.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f1a2500 (Tue Nov 17 17:59:29 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Nov 17, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @twalthr for the contribution, I left only one minor comment

if [[ "$ELASTICSEARCH_VERSION" == 6 ]]; then
DOWNLOAD_URL=$ELASTICSEARCH6_DOWNLOAD_URL
elif [[ "$ELASTICSEARCH_VERSION" == 7 ]] && [[ "$OS_TYPE" == "mac" ]]; then
if [[ "$ELASTICSEARCH_VERSION" == 7 ]] && [[ "$OS_TYPE" == "mac" ]]; then
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: after deleted the test for Es6, the version check can be ignored

@twalthr
Copy link
Copy Markdown
Contributor Author

twalthr commented Nov 18, 2020

Thanks @leonardBang. I removed the version as a parameter. I will merge this if there are no objections.

Copy link
Copy Markdown
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @twalthr , +1 to merge once the build pass

@twalthr twalthr closed this in 71ef64f Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants