[FLINK-17424][e2e] Adopt download strategy of Kafka tests in Elasticsearch tests#14106
[FLINK-17424][e2e] Adopt download strategy of Kafka tests in Elasticsearch tests#14106twalthr wants to merge 3 commits intoapache:masterfrom
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit f1a2500 (Tue Nov 17 17:59:29 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @twalthr for the contribution, I left only one minor comment
| if [[ "$ELASTICSEARCH_VERSION" == 6 ]]; then | ||
| DOWNLOAD_URL=$ELASTICSEARCH6_DOWNLOAD_URL | ||
| elif [[ "$ELASTICSEARCH_VERSION" == 7 ]] && [[ "$OS_TYPE" == "mac" ]]; then | ||
| if [[ "$ELASTICSEARCH_VERSION" == 7 ]] && [[ "$OS_TYPE" == "mac" ]]; then |
There was a problem hiding this comment.
minor: after deleted the test for Es6, the version check can be ignored
|
Thanks @leonardBang. I removed the version as a parameter. I will merge this if there are no objections. |
leonardBang
left a comment
There was a problem hiding this comment.
Thanks for the update @twalthr , +1 to merge once the build pass
What is the purpose of the change
Adds some retry and timeout logic to the Elasticsearch binary download logic.
Additionally, it cleans up the testing matrix a bit to make the e2e tests quicker on Azure.
Brief change log
See commit messages.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation