-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-17424][e2e] Further stabilize Elasticsearch in test_sql_client.sh #14202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit a7c9e34 (Tue Nov 24 13:59:19 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
I just found out that there is a no JDK version as well. It could further shorten the download time. |
|
|
||
| run_test "Elasticsearch (v5.3.3) sink end-to-end test" "$END_TO_END_DIR/test-scripts/test_streaming_elasticsearch.sh 5 https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-5.3.3.tar.gz" | ||
| run_test "Elasticsearch (v6.3.1) sink end-to-end test" "$END_TO_END_DIR/test-scripts/test_streaming_elasticsearch.sh 6 https://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-6.3.1.tar.gz" | ||
| run_test "Elasticsearch (v5.3.3) sink end-to-end test" "$END_TO_END_DIR/test-scripts/test_streaming_elasticsearch.sh 5 http://artifacts.elastic.co/downloads/elasticsearch/elasticsearch-5.3.3.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why's the http version more stable than https?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
80% of all errors are TLS errors, we don't necessarily need TLS if it makes the downloads more stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This PR should be good to go then.
bac1264 to
cac36c0
Compare
cac36c0 to
fd91c2a
Compare
This aims to solve different issues while downloading Elasticsearch binaries. We use wget (specialized in downloading) in the hope for more stability. Furthermore, we implement a retry logic ourselves which includes the successful tar archive extraction in case of corrupt downloads. This closes #14202.
What is the purpose of the change
Another attempt to improve the error rate when downloading Elasticsearch. If this doesn't help, we need to put a loop around
curland retry ourselves. There is a--retry-all-errorsbut this is not available on all machines yet.Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation