Skip to content

Conversation

@godfreyhe
Copy link
Contributor

What is the purpose of the change

Introduce StreamPhysicalChangelogNormalize, and make StreamExecChangelogNormalize only extended from ExecNode

Brief change log

  • Introduce StreamPhysicalChangelogNormalize, and make StreamExecChangelogNormalize only extended from ExecNode

Verifying this change

This change is a refactoring rework covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 9af4e11 (Wed Dec 16 09:36:24 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 16, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

public StreamExecChangelogNormalize(
int[] uniqueKeys,
boolean generateUpdateBefore,
boolean isMiniBatchEnabled,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isMiniBatchEnabled should be determinated in translateToPlan, so that it would be possible to be enabled or disabled dynamically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An ExecNode(with its attributes) should correspond to a specific operator, so that state compatibility is guaranteed

…ormalize, and make StreamExecChangelogNormalize only extended from ExecNode
@godfreyhe
Copy link
Contributor Author

I will merge this pr

@godfreyhe godfreyhe closed this in 5cc3fdf Dec 22, 2020
@godfreyhe godfreyhe deleted the FLINK-20622 branch December 22, 2020 02:57
meijies pushed a commit to meijies/flink that referenced this pull request Dec 28, 2020
…ormalize, and make StreamExecChangelogNormalize only extended from ExecNode

This closes apache#14402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants