-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-20622][table-planner-blink] Introduce StreamPhysicalChangelogNormalize, and make StreamExecChangelogNormalize only extended from ExecNode #14402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9af4e11 (Wed Dec 16 09:36:24 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
9af4e11 to
64e05a3
Compare
| public StreamExecChangelogNormalize( | ||
| int[] uniqueKeys, | ||
| boolean generateUpdateBefore, | ||
| boolean isMiniBatchEnabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isMiniBatchEnabled should be determinated in translateToPlan, so that it would be possible to be enabled or disabled dynamically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An ExecNode(with its attributes) should correspond to a specific operator, so that state compatibility is guaranteed
64e05a3 to
17d1a31
Compare
…ormalize, and make StreamExecChangelogNormalize only extended from ExecNode
17d1a31 to
a475102
Compare
|
I will merge this pr |
…ormalize, and make StreamExecChangelogNormalize only extended from ExecNode This closes apache#14402
What is the purpose of the change
Introduce StreamPhysicalChangelogNormalize, and make StreamExecChangelogNormalize only extended from ExecNode
Brief change log
Verifying this change
This change is a refactoring rework covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation