Skip to content

Conversation

@dannycranmer
Copy link
Contributor

What is the purpose of the change

When consuming from LATEST, the KinesisDataFetcher converts the shard iterator type into an AT_TIMESTAMP to ensure all shards start from the same position. When LATEST is used each shared would effectively start from a different point in the time.

DynamoDB streams do not support AT_TIMESTAMP iterator type and consuming from latest is broken

Brief change log

  • Remove shard iterator type transform for DynamoDB streams consumer to fix consume from LATEST

Verifying this change

  • Added unit test: DynamoDBStreamsDataFetcherTest
  • Deployed application to local Flink cluster and verified consumer works as expected

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

* @return
*/
@Override
protected ShardConsumer<T> createShardConsumer(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overridden method was identical to the super class, hence deleted

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 898816c (Wed Dec 16 14:11:28 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Dec 16, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@tzulitai
Copy link
Contributor

+1, LGTM. Thanks for fixing this @dannycranmer! Merging this master and release-1.12.

@tzulitai tzulitai closed this in 1fcbdb1 Dec 21, 2020
tzulitai pushed a commit that referenced this pull request Dec 21, 2020
meijies pushed a commit to meijies/flink that referenced this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants