Skip to content

[FLINK-20488][runtime][checkpoint] Show checkpoint type in the Web-UI… #14546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pnowojski merged 1 commit into from
Jan 8, 2021
Merged

[FLINK-20488][runtime][checkpoint] Show checkpoint type in the Web-UI… #14546

pnowojski merged 1 commit into from
Jan 8, 2021

Conversation

@curcur
Copy link
Contributor

@curcur curcur commented Jan 4, 2021

… (AC/UC) for each subtask

What is the purpose of the change

In the UI, show checkpoint type for each subtask (add an unaligned checkpoint column for each subtask).

Brief change log

Verifying this change

Existing Unit test and also tested on web-UI

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 4, 2021 •
edited
Loading

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit beada5b (Fri May 28 07:02:34 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 4, 2021 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

rkhachatryan
rkhachatryan requested changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@rkhachatryan rkhachatryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes generally LGTM but not to spotless :) Please fix formatting.
I ran a test job and I think aggregation can be added later as a separate PR.

...b/web-dashboard/src/app/pages/job/checkpoints/subtask/job-checkpoints-subtask.component.html
<th nzSortKey="alignment.processed" nzShowSort><strong>Processed (persisted) Data</strong></th>
<th nzSortKey="alignment.duration" nzShowSort><strong>Alignment Duration</strong></th>
<th nzSortKey="start_delay" nzShowSort><strong>Start Delay</strong></th>
<th nzSortKey="unaligned_checkpoint" nzShowSort><strong>Unaligned Checkpoint</strong></th>
Copy link
Contributor

@rkhachatryan rkhachatryan Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: invert to Aligned to save space?

Copy link
Contributor Author

@curcur curcur Jan 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sure...? The meaning of "Aligned" is ambiguous, and I do not think it is straightforward for users that "Aligned" means "not completed as an unaligned checkpoint"?

Copy link
Contributor

@rkhachatryan rkhachatryan Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a tooltip (and it should be documented).
I'm also fine with "Unaligned Checkpoint".

...src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java Outdated
Comment on lines 300 to 301
LOG.debug(
"Is unaligned checkpoint for task {} : {}",
Copy link
Contributor

@rkhachatryan rkhachatryan Jan 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better place to log is the end of takeSnapshotSync where other properties are logged.

Copy link
Contributor Author

@curcur curcur Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved both the log and metrics update to the end of takeSnapshotSync .

@curcur
Copy link
Contributor Author

curcur commented Jan 5, 2021

The changes generally LGTM but not to spotless :) Please fix formatting.
I ran a test job and I think aggregation can be added later as a separate PR.

hoops, forget to do the formatting ...

@curcur curcur force-pushed the web_ui_unaligned_checkpoint branch from 3c05ee3 to beada5b Compare January 5, 2021 10:54
@curcur
Copy link
Contributor Author

curcur commented Jan 5, 2021

I re-tested after updates.

@curcur
Copy link
Contributor Author

curcur commented Jan 6, 2021

https://dev.azure.com/mymeiyuan/Flink/_build/results?buildId=152&view=results

local azure is green

the cluster azure fails with unrelated tests

pnowojski
pnowojski reviewed Jan 8, 2021
View reviewed changes
Copy link
Contributor

@pnowojski pnowojski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and review @curcur and @rkhachatryan . Merging.

@pnowojski pnowojski merged commit 0abbee9 into apache:master Jan 8, 2021
@curcur curcur deleted the web_ui_unaligned_checkpoint branch January 11, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pnowojski pnowojski pnowojski left review comments

@rkhachatryan rkhachatryan rkhachatryan approved these changes

Assignees

No one assigned

Labels

component=Runtime/Checkpointing component=Runtime/Configuration component=Runtime/WebFrontend review=description?

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@curcur @flinkbot @rkhachatryan @pnowojski @rmetzger