[FLINK-20345][table-planner-blink] Adds an Expand node only if there are multiple distinct aggregate functions in an Aggregate when executes SplitAggregateRule #14602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
An
Expandnode is only necessary when multiple aggregate function with different distinct keys appear in an Aggregate. However an unnecessaryExpandnode will be generated under some special cases, like the following sql.SELECT COUNT(c) AS pv, COUNT(DISTINCT c) AS uv FROM T GROUP BY a.
This pull request aims to avoid generate unnecessary
Expandnode.Brief change log
SplitAggregateRulecheck only need expand if there are multiple distinct aggregate functions in an AggregateVerifying this change
This change is already covered by existing tests, such as
SplitAggregateITCase,DistinctAggregateTest,SplitAggregateRuleTest. Besides, this change added IT and UT inSplitAggregateITCaseandSplitAggregateRuleTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation