-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-20948][table-planner-blink] Introduce StreamPhysicalDeduplicate, and make StreamExecDeduplicate only extended from ExecNode #14626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 9bf8957 (Fri May 28 07:07:41 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
wenlong88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a reminder to update the out-of-date doc.
| * Stream physical RelNode which deduplicate on keys and keeps only first row or last row. | ||
| * This node is an optimization of [[StreamPhysicalRank]] for some special cases. | ||
| * Compared to [[StreamPhysicalRank]], this node could use mini-batch and access less state. | ||
| * <p>NOTES: only supports sort on proctime now, sort on rowtime will not translated into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the doc is out of date, deduplicate based on rowtime is supported now.
…e, and make StreamExecDeduplicate only extended from ExecNode
c5c5c07 to
9bf8957
Compare
…e, and make StreamExecDeduplicate only extended from ExecNode This closes apache#14626
What is the purpose of the change
Separate the implementation of StreamExecDeduplicate
Brief change log
Verifying this change
This change is a refactoring rework covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation