-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql #14742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-21069][table-planner-blink] Configuration "parallelism.default" doesn't take effect for TableEnvironment#explainSql #14742
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 2ce2e5d (Fri May 28 07:13:14 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
Compile is failed. |
…doesn't take effect for TableEnvironment#explainSql
|
@wuchong, sorry for the failure of scala style compile. I have updated the violation of |
...ink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
Outdated
Show resolved
Hide resolved
...ink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
Outdated
Show resolved
Hide resolved
…doesn't take effect for TableEnvironment#explainSql
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
The configuration
parallelism.defaultfor table environment doesn't take effect forTableEnvironment#explain. BecausePlannerBase#translateToReldoesn't invokeoverrideEnvParallelismwhich configures the configuration into underlyingStreamExecutionEnvironmentand is invoked intranslate. MethodoverrideEnvParallelismshould be invoked intranslateToReland removed fromtranslate.Brief change log
PlannerBase#translateToRelinvokes the methodoverrideEnvParallelismwhich configures the configuration into underlyingStreamExecutionEnvironment.Verifying this change
testStreamTableEnvironmentExecutionExplainofTableEnvironmentTestto verify the test case whether the configurationparallelism.defaulttakes effect inTableEnvironment#explainSqlor not.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation