Skip to content

[FLINK-21204][coordination] Remove LogicalSlot#getSlotSharingGroupId#14808

Merged
zentol merged 1 commit intoapache:masterfrom
zentol:21204
Feb 3, 2021
Merged

[FLINK-21204][coordination] Remove LogicalSlot#getSlotSharingGroupId#14808
zentol merged 1 commit intoapache:masterfrom
zentol:21204

Conversation

@zentol
Copy link
Copy Markdown
Contributor

@zentol zentol commented Jan 29, 2021

The slotSharingGroupId is always set to null and never accessed outside of a single test (which also just checked that it is indeed null).

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Jan 29, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 232c042 (Fri May 28 08:17:01 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Jan 29, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @zentol. LGTM. +1 for merging this PR.

@zentol zentol merged commit 21a36f8 into apache:master Feb 3, 2021
@zentol zentol deleted the 21204 branch February 8, 2021 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants