Upgrade monaco-editor to fix scroll bug in Firefox#14833
Closed
lovelock wants to merge 2 commits intoapache:masterfrom
lovelock:patch-1
Closed
Upgrade monaco-editor to fix scroll bug in Firefox#14833lovelock wants to merge 2 commits intoapache:masterfrom lovelock:patch-1
lovelock wants to merge 2 commits intoapache:masterfrom
lovelock:patch-1
Conversation
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 548b967 (Fri May 28 08:16:20 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Author
|
comment to rerun check
…------------------ Original ------------------
From: flinkbot <notifications@github.com>
Date: Tue,Feb 2,2021 6:29 PM
To: apache/flink <flink@noreply.github.com>
Cc: Frost Wong <happyhackerwqc@foxmail.com>, Author <author@noreply.github.com>
Subject: Re: [apache/flink] Upgrade monaco-editor to fix scroll bug in Firefox (#14833)
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
Automated Checks
Last check on commit a068b3e (Tue Feb 02 10:29:19 UTC 2021)
Warnings:
No documentation files were touched! Remember to keep the Flink docs up to date!
Invalid pull request title: No valid Jira ID provided
Mention the bot in a comment to re-run the automated checks.
Review Progress
❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.
Please see the Pull Request Review Guide for a full explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:
@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see this microsoft/monaco-editor#1353
What is the purpose of the change
Brief change log
upgrade monaco-editor to
^0.22.3Verifying this change
I merely know how to build flink from source, maybe the feature has never been tested in Firefox.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation