-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-21088][runtime][checkpoint] Pass the flag about whether a task is finished on restore on recovery #14861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 8f28386 (Thu Sep 23 18:02:11 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
2131028 to
9e2a17b
Compare
9e2a17b to
b460330
Compare
c3a823c to
8ba0101
Compare
2fe9bfe to
85048e5
Compare
|
Hi @dawidwys , could you have a look at this PR when convenient~? This is the first of the two PR regarding restoring finished state. |
dawidwys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. If possible I'd really like to avoid exposing the isFinishedOnRestore flag in the StreamTaskStateInitializer
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/TaskStateSnapshot.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/state/TaskStateManager.java
Outdated
Show resolved
Hide resolved
...-java/src/main/java/org/apache/flink/streaming/api/operators/StreamTaskStateInitializer.java
Outdated
Show resolved
Hide resolved
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
Outdated
Show resolved
Hide resolved
… if operators are all finished on restore
…s to TaskStateManager
…to operator chain
85048e5 to
8f28386
Compare
|
Hi @dawidwys very thanks for the review! I updated the PR according to the comments~ I directly modified the original commits since there is a part of code get reverted~ |
|
Thanks for the update! Looks good. I'll wait for Azure and then merge it. |
|
@flinkbot run azure |
What is the purpose of the change
For checkpoints after tasks finished, if some operators are fully finished, it would store a special state content in the checkpoint metadata. After recovery, the flag of whether the operator is fully finished should be passed to the task side so that these operator could skip execution (which would be implemented in the next PR).
Brief change log
Verifying this change
This change added tests and can be verified via added ut.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation