Skip to content

Conversation

@gaoyunhaii
Copy link
Contributor

What is the purpose of the change

For checkpoints after tasks finished, if some operators are fully finished, it would store a special state content in the checkpoint metadata. After recovery, the flag of whether the operator is fully finished should be passed to the task side so that these operator could skip execution (which would be implemented in the next PR).

Brief change log

  • 2131028 passes the flag to the task.

Verifying this change

This change added tests and can be verified via added ut.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 4, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8f28386 (Thu Sep 23 18:02:11 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 4, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@gaoyunhaii gaoyunhaii force-pushed the final_cp_8_21088 branch 3 times, most recently from c3a823c to 8ba0101 Compare July 12, 2021 03:12
@gaoyunhaii gaoyunhaii changed the title [FLINK-21088][runtime][checkpoint] Pass the flag about whether a operator is fully finished on recovery [FLINK-21088][runtime][checkpoint] Pass the flag about whether a task is finished on restore on recovery Jul 12, 2021
@gaoyunhaii gaoyunhaii force-pushed the final_cp_8_21088 branch 2 times, most recently from 2fe9bfe to 85048e5 Compare July 12, 2021 04:19
@gaoyunhaii
Copy link
Contributor Author

Hi @dawidwys , could you have a look at this PR when convenient~? This is the first of the two PR regarding restoring finished state.

Copy link
Contributor

@dawidwys dawidwys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. If possible I'd really like to avoid exposing the isFinishedOnRestore flag in the StreamTaskStateInitializer

@gaoyunhaii
Copy link
Contributor Author

Hi @dawidwys very thanks for the review! I updated the PR according to the comments~ I directly modified the original commits since there is a part of code get reverted~

@dawidwys
Copy link
Contributor

Thanks for the update! Looks good. I'll wait for Azure and then merge it.

@dawidwys
Copy link
Contributor

@flinkbot run azure

@dawidwys dawidwys merged commit 5aba616 into apache:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants