Skip to content

Conversation

@klook-tech-jayyang
Copy link
Contributor

What is the purpose of the change

FLINK-21176
Translate the updates of 'avro-confluent.zh.md' to Chinese

Brief change log

  • Translate the updates to Chinese, doc location is 'docs/dev/table/connectors/formats/avro-confluent.zh.md'

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not documented

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 8, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3fc334c (Mon Feb 08 09:11:00 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 8, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@klook-tech-jayyang
Copy link
Contributor Author

Hi, @wuchong , could you help to review this? thanks.

@wuchong
Copy link
Member

wuchong commented Feb 10, 2021

@fsk119 could you help to review this?

@sjwiesman
Copy link
Contributor

Hi @jjey

Thank you for working on this translation! Can you please rebase this change on master, we recently migrated Flinks documentation to Hugo from Jekyll. You can find full details on building the new documentation locally, along with our provided "shortcodes" in docs/README.md

@klook-tech-jayyang
Copy link
Contributor Author

klook-tech-jayyang commented Feb 13, 2021

Hi @sjwiesman

Just finished. Thanks for your suggestion.

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. LGTM except one minor suggestions.

@klook-tech-jayyang
Copy link
Contributor Author

Thanks @fsk119 for your review comments. I've updated and commited the modifications.
And Happy Niu Year to @fsk119 and @wuchong.

Copy link
Member

@fsk119 fsk119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your wishes! Happy niu year =-=

It would be fine if you could fix the last minor comments.

@fsk119
Copy link
Member

fsk119 commented Feb 22, 2021

Thanks for your update @jjiey . Cheers!

CC @wuchong

@klook-tech-jayyang
Copy link
Contributor Author

Cheers! Thanks @fsk119 for your guidance!

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wuchong wuchong merged commit d20635f into apache:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants