-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-21176][docs] translate the updates of 'avro-confluent.zh.md' to Chinese #14896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3fc334c (Mon Feb 08 09:11:00 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
Hi, @wuchong , could you help to review this? thanks. |
|
@fsk119 could you help to review this? |
|
Hi @jjey Thank you for working on this translation! Can you please rebase this change on master, we recently migrated Flinks documentation to Hugo from Jekyll. You can find full details on building the new documentation locally, along with our provided "shortcodes" in |
c37ae40 to
cf343b4
Compare
|
Hi @sjwiesman Just finished. Thanks for your suggestion. |
fsk119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response. LGTM except one minor suggestions.
docs/content.zh/docs/connectors/table/formats/avro-confluent.md
Outdated
Show resolved
Hide resolved
a5f4e50 to
b968335
Compare
fsk119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your wishes! Happy niu year =-=
It would be fine if you could fix the last minor comments.
b968335 to
36a7b88
Compare
|
Thanks for your update @jjiey . Cheers! CC @wuchong |
36a7b88 to
387a577
Compare
|
Cheers! Thanks @fsk119 for your guidance! |
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
FLINK-21176
Translate the updates of 'avro-confluent.zh.md' to Chinese
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation