Skip to content

FLINK-2551 Fix Several Bugs in Input/Output Formats#1497

Closed
ndimiduk wants to merge 1 commit intoapache:masterfrom
ndimiduk:2551-FileSinkFunction-delegate-InputTypeConfigurable
Closed

FLINK-2551 Fix Several Bugs in Input/Output Formats#1497
ndimiduk wants to merge 1 commit intoapache:masterfrom
ndimiduk:2551-FileSinkFunction-delegate-InputTypeConfigurable

Conversation

@ndimiduk
Copy link
Copy Markdown
Member

This is a patch that fixes the last issue listed on the ticket description, "The Streaming API does not call setInputType if a format implements InputTypeConfigurable". I don't know why my application code exercises this code path while none of the uses of DataStream.write in the flink test code do. This patch also applies cleanly on the release-0.10 branch.

@fhueske
Copy link
Copy Markdown
Contributor

fhueske commented Jan 12, 2016

Thanks for the PR.
Looks good to merge!

@aljoscha
Copy link
Copy Markdown
Contributor

+1

@ndimiduk ndimiduk force-pushed the 2551-FileSinkFunction-delegate-InputTypeConfigurable branch from 2d5c1bf to e22c299 Compare January 12, 2016 17:24
@ndimiduk
Copy link
Copy Markdown
Member Author

Reworded the commit message for the appropriate subtask. This patch applies cleanly on both master and the release-0.10 branches.

@fhueske
Copy link
Copy Markdown
Contributor

fhueske commented Jan 12, 2016

Thanks for the update. Will merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants