Skip to content

Conversation

@Sunt-ing
Copy link

@Sunt-ing Sunt-ing commented Feb 22, 2021

What is the purpose of the change

Fix broken links in content.zh/docs/concepts/flink-architecture.md

When reading the Chinese doc I find some links are broken and the responses for these links are 404. And I find that this is because of the format error: these links are different from their corresponding original links in the English doc, while the links which are identical to the corresponding links in the English doc are OK for me.

See line 36 in content.zh/docs/concepts/flink-architecture.md and line 42 in content/docs/concepts/flink-architecture.md, they are same and this image is OK in the Chinese doc. But the other links in the file are not and thus the images cannot be shown.

You may check this by clicking:
English doc: https://ci.apache.org/projects/flink/flink-docs-master/docs/concepts/flink-architecture/
Chinese doc: https://ci.apache.org/projects/flink/flink-docs-master/zh/docs/concepts/flink-architecture/

Brief change log

Change the formats of these links by replacing broken links with the corresponding links in the English doc.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

…hitecture.md

When reading the Chinese doc I find some links are broken and the responses for these links are 404. And I find that this is because of the format error:  these links are different from their corresponding original links in the English doc, while the links which are identical to the corresponding links in the English doc are OK for me.
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 82b390a (Mon Feb 22 12:28:41 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!
  • This pull request references an unassigned Jira ticket. According to the code contribution guide, tickets need to be assigned before starting with the implementation work.

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 22, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@MartijnVisser
Copy link
Contributor

@Sunt-ing Apologies for the super late look, but it appears that your PR has already been resolved since because https://nightlies.apache.org/flink/flink-docs-master/zh/docs/concepts/flink-architecture/ looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants