[FLINK-2984] [ml] Extend libSVM file format support#1504
Closed
chiwanpark wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-2984] [ml] Extend libSVM file format support#1504chiwanpark wants to merge 1 commit intoapache:masterfrom
chiwanpark wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Changes look good. +1 for merging. |
Member
Author
|
Thanks for review @tillrohrmann! I'll merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, FlinkML libSVM file reader cannot read some datasets (such as splice-site) in libSVM official site. This PR extends libSVM file format to liblinear equivalent. To avoid re-compiling regex pattern in every line, I changed the mapper from scala lambda function to
RichFlatMapFunction.