-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-21710][table-planner-blink] FlinkRelMdUniqueKeys gets incorrect result on TableScan after project push-down #15138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit caf54ac (Wed Mar 10 09:53:35 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
…t result on TableScan after project push-down
|
LGTM! |
|
Thanks for the review @lincoln-lil , I will merge this pr |
…t result on TableScan after project push-down This closes apache#15138 (cherry picked from commit 0297b84)
…t result on TableScan after project push-down This closes apache#15138 (cherry picked from commit 0297b84)
What is the purpose of the change
FlinkRelMdUniqueKeys#getTableUniqueKeys uses the original columns to find the index of primary keys. But after project push-down, the indexes is incorrect based on original columns, and the new columns should be used. This pr aims to fix it.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation