Skip to content

Conversation

@pengkangjing
Copy link
Contributor

@pengkangjing pengkangjing commented Mar 16, 2021

What is the purpose of the change

fix the check that whether JobLeaderIdService has been started. More details you can find in FLINK-21910.

Brief change log

fix the check that whether JobLeaderIdService has been started

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit cd66720 (Tue Mar 16 06:13:30 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 16, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@zentol
Copy link
Contributor

zentol commented Mar 18, 2021

Please file a JIRA ticket for this issue. We should also add a test to ensure this issues does not occur again.

@zentol zentol self-assigned this Mar 18, 2021
@pengkangjing pengkangjing force-pushed the pengkangjing-jobleaderidservice branch from cd66720 to a33e6bd Compare March 22, 2021 09:04
@pengkangjing pengkangjing reopened this Mar 22, 2021
@pengkangjing pengkangjing changed the title [hotfix][resourceManager] fix the check that whether JobLeaderIdServi… [Flink-21910][resourcemanager] fix the check that whether JobLeaderIdService has been stated Mar 22, 2021
@pengkangjing pengkangjing force-pushed the pengkangjing-jobleaderidservice branch from 3de215b to 8908476 Compare March 22, 2021 09:40
@pengkangjing pengkangjing force-pushed the pengkangjing-jobleaderidservice branch 2 times, most recently from a43fac0 to af9cc6e Compare March 23, 2021 02:39
@pengkangjing pengkangjing force-pushed the pengkangjing-jobleaderidservice branch from af9cc6e to 46ae634 Compare March 23, 2021 04:17
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR @pengkangjing. The changes look good to me. Merging this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants