Skip to content

Conversation

@SteNicholas
Copy link
Member

What is the purpose of the change

Currently we have discussed the grammar about multi-line statements as follows:

BEGIN STATEMENT SET;
INSERT INTO ... SELECT ...;
INSERT INTO ... SELECT ...;
END;

SqlParser should support STATEMENT SET syntax in TableEnvironment.

Brief change log

  • Add SqlStatementSet to support STATEMENT SET syntax for SqlParser.

Verifying this change

  • FlinkSqlParserImplTest adds testStatementSetWithSingleInsertInto, testStatementSetWithMultiInsertInto, testStatementSetWithoutInsertInto and testStatementSetWithCreateTable to verify whether SqlParser supports the STATEMENT SET syntax.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 19, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d294c11 (Sat Aug 28 10:34:00 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 19, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@fsk119
Copy link
Member

fsk119 commented Mar 22, 2021

Thanks for your contribution @SteNicholas.

I have some thoughts about this PR. Because our goal is to submit statement set in the sql client. However, the Executor is just a wrapper of the TableEnvironment that can notice the Operation rather than SqlNode. Therefore, we need to introduce operations.

The second question is how sql client submits statement. In the FLIP, we reach consensus that the desired behaviour looks like

Flink SQL> BEGIN STATEMENT SET;
 
[Info] Begin the statement set.
 
Flink SQL> INSERT INTO emps1 SELECT * FROM emps(x, y);
 
[Info] Add the statement into the statement set.
 
Flink SQL> INSERT INTO emps2 SELECT * FROM emps(x, y);
 
[Info] Add the statement into the statement set.
 
Flink SQL> END;
 
[Info] Submitting SQL statement set to the cluster...

I think the proposed grammer may not achieve the final goal.

@SteNicholas
Copy link
Member Author

@wuchong @fsk119 , I have followed the statement set syntax as follows:

BEGIN STATEMENT SET;
INSERT INTO xx SELECT * FROM xxx;
END;

Please help to review this update for the statement set syntax.

@SteNicholas
Copy link
Member Author

@wuchong , thanks for detailed review. I have followed your comments and only supported the statement set parser. Please help to review again.

@SteNicholas SteNicholas requested a review from wuchong March 28, 2021 01:48
Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuchong wuchong merged commit b19538d into apache:master Mar 28, 2021
wuchong pushed a commit to zoucao/flink that referenced this pull request Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants