-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-21664][table-api] Support STATEMENT SET syntax in TableEnvironment #15282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit d294c11 (Sat Aug 28 10:34:00 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
Thanks for your contribution @SteNicholas. I have some thoughts about this PR. Because our goal is to submit statement set in the sql client. However, the The second question is how sql client submits statement. In the FLIP, we reach consensus that the desired behaviour looks like I think the proposed grammer may not achieve the final goal. |
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/SqlEnd.java
Outdated
Show resolved
Hide resolved
...table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/EndOperation.java
Outdated
Show resolved
Hide resolved
|
@wuchong , thanks for detailed review. I have followed your comments and only supported the statement set parser. Please help to review again. |
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
Currently we have discussed the grammar about multi-line statements as follows:
SqlParsershould supportSTATEMENT SETsyntax inTableEnvironment.Brief change log
SqlStatementSetto supportSTATEMENT SETsyntax forSqlParser.Verifying this change
FlinkSqlParserImplTestaddstestStatementSetWithSingleInsertInto,testStatementSetWithMultiInsertInto,testStatementSetWithoutInsertIntoandtestStatementSetWithCreateTableto verify whetherSqlParsersupports theSTATEMENT SETsyntax.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation